Documentation Tool: Unable to view all content

Description

See examples mentioned here: https://h5p.org/comment/15734#comment-15734

It appears the Documentation Tool does not resize to fit the content when going to the next step.

Environment

None

Acceptance Criteria

Must be able to see all content on all steps of documentation tool.
Export must work the same way it worked for previous versions.

Activity

Show:
Steve Bilton
October 4, 2017, 1:03 PM
Edited

I just manually updated to the master version on git, which states documentation tool is 1.5.3.

The problem is rectified in the master version; there are around 200 more lines of code in this file (/wp-content/uploads/h5p/libraries/H5P.DocumentationTool-1.5/documentation-tool.js) between the git master version compared to the published h5p version.

Although I notice that the export to document is not working properly at all in 1.5.3 version, so I have deleted the library, added the single line of code in the previous comment, re-uploaded as version 1.5.2 and the issue is resolved.

v 1.5.3 still needxs work.

Svein-Tore Griff With
October 5, 2017, 4:20 PM

Sounds like a blocker yes. (I've made it a blocker)

Pål Jørgensen
October 5, 2017, 9:09 PM

I have fixed this directly on the stable branch, which is the new 1.5.3 (tags on release branch is deleted). Tested the examples showing the problem on h5p.org, no regression-problems found.

: Thanks for reporting. You say "export to document" is not working at all. When seeing that, did you update only H5P.DocumentationTool from git? Doctool is dependent on many libraries, and these have to be updated as well.

Steve Bilton
October 6, 2017, 8:43 AM
Edited

I don't think I updated the export library, which is located here: /wp-content/uploads/h5p/libraries/H5P.DocumentExportPage-1.2

The export does work, but does not arrange the page elements correctly. For example one export I notice the first few pages are ok, then a repetition of the same input field information is displayed. Like so...

Normal page content goes here.
Then one of the input fields repeats itself at the bottom of the export, but does not export all of the fields too.

Input field text content here

Input field text content here

Input field text content here

Input field text content here

Another issue with the export is html formatting is contained within the export and really ruins the output format - it's not very 'pretty'. So, the only workaround is to avoid any styling at all in content.

Input field issue
Also input fields that are set to be required do not indicate a required field, usually this is done by adding an asterisk symbol (red/green when data not entered?). So, if a user misses a required input field, this is not immediately obviously which field was missed and it can take a long time to locate it.

Pål Jørgensen
October 6, 2017, 9:01 AM

The code found on the master & release branch is not regression-tested yet, so there might be problems there.

The issue about HTML outputted into the exported document is a known problem. It probably won't be fixed now.

The required fields get a star on the newest code

Done

Assignee

Pål Jørgensen

Reporter

Frode Petterson

Labels

Funding

None

Code reviewer

None

Released

None

Time tracking

0m

Time remaining

0m

Fix versions

Sprint

None

Priority

Highest