IV: Video quality chooser not working for YT

Description

Example here:
https://h5p.org/node/184001

Video quality chooser does not seem to work for YouTube sources. I have not tested for uploaded video

Environment

None

Acceptance Criteria

If qualities are available, they shall be choosable

Activity

Show:
Pål Jørgensen
March 5, 2018, 12:12 PM

I see you have removed setQuality/getQuality from the YouTube player. I think we should keep the functions since the different players kindof implement an interface. In that way, you don't need the changes done in IV. : Do you agree with me?

Frode Petterson
March 5, 2018, 12:24 PM

Hm, yes I'm not sure what's the most common thing to do here. By removing it completely we might get someone saying "Hey, why's this not implemented?"

One little thing I observed was that the quality actually changes when you change the size of the IV or enter fullscreen. Maybe we could have the menu there just for people to verify the quality, but disable the buttons?

Oliver Tacke
March 5, 2018, 12:56 PM

Yes, YouTube still triggers the QualityChanged event if they change it, but you cannot set it yourself any longer.

Should the popup contain all the quality options that YouTube could set it to or rather only the current one? The first option might also be confusing: "Why can't I click on the quality option?"

Oliver Tacke
March 5, 2018, 5:51 PM

I made the required changes. If it's a YouTube video, the user will only see the current video quality (that's updates when YouTube changes it) instead of all the options.

Frode Petterson
April 20, 2018, 8:45 AM

Looks good!
Merged into master.

Assignee

Oliver Tacke

Reporter

Pål Jørgensen

Labels

None

Funding

None

Code reviewer

Pål Jørgensen

Released

None

Time tracking

2h

Fix versions

Sprint

None

Priority

Medium
Configure