Requesting H5P Essay Review/Update

Description

H5P Essay has been updated. It now implements some features that users have been asking for:

  • Add optional image or video on as an introduction

  • Implement the Question type contract, so it should now be ready for Question Set (multiple people have asked for that already). It also should now supprt the moodle gradebook.

  • Add Dutch translation (contributed by Rene Breedveld)

  • Add Italian translation (contributed by Gerardo Fallani)

  • Add Spanish translation (contributed by Germán Valero)

  • Add Mexican Spanish translation (contributed by Germán Valero)

  • Add regular expressions as an optional format for keywords (for experienced users)

Diff to version on h5p.org
https://github.com/otacke/h5p-essay/compare/53e271c480aa2b947822753ec4736e33a1159f92...release

Release files
https://github.com/otacke/h5p-essay/releases/tag/1.1.3

Acceptance Criteria

  • contract implementation is complete

  • moodle gradebook support works as to be expected

Activity

Show:
Oliver Tacke
May 7, 2019, 9:04 AM

I know about Dictation (since you told me about the reporting). I assume it would be a good idea to update the question type contract documentation with a hint at least that returning a proper xAPI statement is not enough, but it will have to support the capabilities of the reporting module as well.

I have not noticed any PHP warnings in the error log, but maybe I need to change the error reporting settings. I'll also check what's wrong with upgrading content.

Oliver Tacke
May 7, 2019, 11:33 AM


I added default values in the code if they are missing and also included an upgrade script. That's fine now.

I also learned that moodle has it's own settings for displaying PHP errors, that's why I didn't notice anything. That's also fixed now in reporting. Sorry for the inconvenience.

I will also create a separate long-fill-in processor, as Frode rightfully mentioned that the design should probably be different. The fill-in processor will now use the same style for "given" answers that don't have a right or wrong as used in the choice-processor. Works, but looks a little odd.

Thomas Marstrander
May 8, 2019, 11:43 AM

The essay changes works well! I have no more comments for it. I have left a review on the long-fill-in processor in the reporting module pull request. We'll handle that from there. It's mainly about reducing the code duplication.

Thomas Marstrander
May 8, 2019, 11:44 AM

Before this can be released the reporting should be properly in place.

Oliver Tacke
January 16, 2020, 12:35 PM

Just to create a “ping”: The amendments to the reporting module that are referenced above can be found at and

Assignee

Oliver Tacke

Reporter

Oliver Tacke

Labels

Funding

None

Code reviewer

Thomas Marstrander

Released

None

Time tracking

4h

Sprint

None

Fix versions

Priority

High
Configure