H5P.MathDisplay causing scrollbar in CP

Description

Acceptance Criteria

No scrollbars when we don't need them.

Background

There’s plenty of room, but the inner dom element creates a scrollbar. Not seen if you have opacity > 0 for the CP element

Environment

None

Acceptance Criteria

None

Activity

Show:
Oliver Tacke
September 6, 2018, 7:09 AM

I mentioned that problem in already. Wasn't sure if changing the CSS would break some existing content.

— "There's one small visual glitch in Course Presentation that I found briefly before I left for my vacation. If you use the inline notation, e.g. (mathContent) inside a text box and it only uses the space for one line, then you'll have a tiny scrollbar for this one line, even if there's enough space in the textbox. Fixing this should be possible by changing the CSS related to the line height/overflow in CP slightly (why should there be an overflow for one line if the box is taller?), but I'd rather have someone confirm that this probably won't break existing content. So, dear future reviewer, what do you think?"

Svein-Tore Griff With
September 9, 2018, 8:14 PM

I didn't understand your comment , but texts in CP should not have scrollbars at all. They should be overflow hidden. Have we brought them back?

Oliver Tacke
September 9, 2018, 8:35 PM

I have not looked into the details of the cause, but inline math seems to trigger the overflow for this one line. Probably simple to fix, and if no textbox should ever have a scrollbar, then there's nothing to break be stopping overflow completely.

Assignee

Pål Jørgensen

Reporter

Pål Jørgensen

Labels

Funding

None

Code reviewer

None

Released

None

Time tracking

0m

Time remaining

0m

Fix versions

None

Sprint

None

Priority

Medium
Configure