Top menu steps design in IV, Find the Hotspot and Drag and Drop - implementation

Description

  • Implement the new top menu ( steps menu ) for IV, Find the Hotspot and Drag and Drop.

  • Implement the new line with buttons at the bottom - for next/previous tasks.

All the steps are attached as separate img in this task, for IV, Find the Hotspot and Drag and Drop.

Latest version of icon library can be found here https://h5ptechnology.atlassian.net/secure/attachment/12706/12706_h5p-core-16.zip

Acceptance Criteria

IV, Find the Hotspot and Drag and Drop gets new look for the steps menu.
IV, Find the Hotspot and Drag and Drop gets prev/next buttons.

Activity

Show:
Andreas Nergaard
March 8, 2017, 10:17 AM

Please have a look now.

Thomas Marstrander
March 10, 2017, 1:45 PM

Code review:
1) Read comments i've made on commits and address them.
2) It seems like the logic is the same in all editor libraries for stepChanges, perhaps this logic could just be moved into editor wizard ?

Wizard Editor:
1) Wizard editor has some very terse code. Please split it into readable chunks and comment where appropriate.
2) If possible please move the logic/state from DOM to JS.

The rest looks good, but please be sure to check through the comments on the commits

Andreas Nergaard
March 13, 2017, 1:32 PM
Edited

I think I covered everything, I'll send it to UX Review again .

Thomas Marstrander
March 14, 2017, 6:26 PM

Excellent work, that refactor made a world of difference
I have merged in all the branches to master.

You have a duplicate declaration of currentTabId in updateWizardNavigation, just fix this on master, then you can drag it to done. Good work

Andreas Nergaard
March 15, 2017, 7:56 AM

Should be ok now

Done

Assignee

Andreas Nergaard

Reporter

Jelena Milinovic

Labels

Funding

None

Code reviewer

Thomas Marstrander

Released

Released

Time tracking

0m

Time remaining

0m

Fix versions

Priority

High