Preview mode issues

Description

Acceptance criteria

  1. Branching question should work in preview mode.

  2. Branching scenario should look the same in preview mode and upon saving (size of it should be the same)

Description

  1. During testing a user created content in which alternatives did not work in preview mode. Can be tested here: https://h5p.org/node/474348

  2. User complained about preview mode not looking the same as when she saved content:

Environment

None

Acceptance Criteria

None

Activity

Show:
Hanna Eide Solstad
January 13, 2021, 11:02 AM

After looking a bit more into it I agree with that this is a bit difficult to solve.

In the preview mode (and saved content) the height comes from the element it contains. Resizing if needed to make sure the height is the same as the elements it contains.

The width in the preview mode is restricted by the width of the editor, which is set. Therefore the ratio will differ, as it also will on a smaller screen vs a larger screen.

One solution is to remove the max-width which is now set on the preview mode which will make it fill the whole view at all time. What do you think about that , do you rather prefer it having a max-width so there is some space on the side when it has room for it?

Jelena Milinovic
January 13, 2021, 11:42 AM

I understand . In that case I prefer having the max-width set as today.
Could we at least get the same max-width in full-screen mode? Since here the preview container is not restricted by the width of the editor.

Hanna Eide Solstad
January 13, 2021, 12:15 PM

That is possible doable, but I don’t think it will be correct every time because the width of the editor may differ from the actual shown content. For example shown below where the editor has less size than the actual content shown. But the max-width while in fullscreen editing mode could at least be higher so it is closer to the saved content, even though not being exactly right? Does that sound okay ?

Hanna Eide Solstad
January 13, 2021, 1:15 PM

We will go with the easy fix i suggested in the last comment , which will make it correct on H5P.com and good enough on the other pages . Adding a max-width of 68em to the preview wrapper when in fullscreen. Will you fix that?

Simon Date
January 13, 2021, 4:39 PM

all done

Done

Assignee

Simon Date

Reporter

Jelena Milinovic

Funding

None

Code reviewer

Hanna Eide Solstad

Released

None

Time tracking

0m

Time remaining

0m

Fix versions

None

Sprint

None

Priority

Medium