Add a gif inside the "Replace" dialog

Description

Acceptance criteria

  • Add a visual (gif) inside the "Replace" dialog that visually shows what will happen if you confirm replacing of the node

Design spec.

Demo: https://preview.uxpin.com/e46f2ef101228ada2e446d4ab0bea0f6c67092bb#/pages/134942466/simulate/no-panels?mode=i
The animation:

Acceptance Criteria

None

Activity

Show:
Hanna Eide Solstad
January 18, 2021, 12:48 PM

It seems to work exactly as expected Ravi, that is very good!

Regarding the code changes I think you did a bit of unnecessary refactoring of the code. We want to have components that are as reusable as possible and also avoid copying code when not needed. Here I would suggest to instead adjust the Dialog component to be able to take in a picture. You could import the graphic in ConfirmationDialog.js and have it set as one of the options in the switch as title, question and confirm are set now. In the dialog graphics can be shown if it is sent.

Hanna Eide Solstad
January 18, 2021, 3:11 PM

Very good Ravi, I just added some more comments related to generalizing even more!

Hanna Eide Solstad
January 19, 2021, 3:02 PM

Excellent!

Done

Assignee

Ravikiran Majithia

Reporter

Jelena Milinovic

Funding

None

Code reviewer

Hanna Eide Solstad

Released

None

Time tracking

0m

Time remaining

0m

Sprint

None

Priority

Medium