Review Image Juxtaposition V1.4

Description

Please give the update of Image Juxtaposition a UX review (not sure if it's really required, as UX is essentially the same, You know where to find the updated version for testion) a code review, and release it.

Acceptance criteria

  • UX is fine

  • Code is fine

Background

I finally managed to give Image Juxtaposition a complete overhaul. There's not much left of the original code (but I kept the messy CSS class names in order to not mess with customization unless you think I could safely change them). It now uses the usual build chain, now all my content types are jQuery-free, the code is split into several classes, the code has been refactored, ... Now I don't have to be ashamed of the code anymore

Code

https://github.com/otacke/h5p-image-juxtaposition

New features

  • Has a loading spinner which is useful for high resolution images/small bandwidth

  • Allows to set the color of the handle to adjust it to the background colors

  • Offers a fullscreen mode

  • Comes with new translations: Greek (found in e-me's fork) and Finnish (contributed by Jarvil)

Problems solved

  • Resizing is now fine, so using Juxtaposition without the action bar works, and it could be included in Column as well (tested)

  • Images now can have an ALT tag (when upgrading, the previous label (if present) will be used for the ALT tag, so Juxtaposition should now be accessible - although there's not much purpose using the handle to slide from one image to the other.

  • There was a 1 pixel offset between both images that's gone now.

Acceptance Criteria

None

Status

Assignee

Thomas Marstrander

Reporter

Oliver Tacke

Funding

None

Code reviewer

None

Released

None

Time tracking

6h

Sprint

None

Fix versions

Priority

Medium
Configure