Decide about "quick win" pull requests and close or merge in

Description

Acceptance Criteria

All of Oliver's pull requests that are listed below are either rejected and closed or reviewed, accepted and merged into the default branch.

Description

There a many pull requests piling up. It's quite understandable if the H5P core team doesn't have the resources to check them all in a timely manner, especially if those pull requests were unexpected. However, some have been open for years, and keeping those updated and resolving conflicts, also consumes contributors' time. It was great if at least some could be either rejected (would be totally fine) or reviewed, accepted and merged into the original code. Here are 15 of my very "quick wins" that should be reviewable swiftly (most of them are one liners):

  1. h5p-editor-php-library: Trigger on list item moved (https://github.com/h5p/h5p-editor-php-library/pull/113)

  2. h5p-blanks: Fix overflow when growing fields cause line breaks (https://github.com/h5p/h5p-blanks/pull/59)

  3. h5p-speak-the-words-set: Fix HTML encoding in introduction title (https://github.com/h5p/h5p-speak-the-words-set/pull/18) for

  4. h5p-link: Fix ampersand & being html encoded (https://github.com/h5p/h5p-link/pull/19)

  5. h5p-wordpress-plugin: Add title attribute to iframe (improve a11y) (https://github.com/h5p/h5p-wordpress-plugin/pull/111)

  6. h5p-wordpress-plugin: Fix check for "install_recommended_h5p_libraries" capability (https://github.com/h5p/h5p-wordpress-plugin/pull/109)

  7. h5p-wordpress-plugin: Add overflow-x scrollbar for data views that are too narrow (https://github.com/h5p/h5p-wordpress-plugin/pull/108)

  8. h5p-question-set: Fix intro image scaling if used in compound content types (https://github.com/h5p/h5p-question-set/pull/55)

  9. h5p-php-report: Fix correct responses pattern being NULL (https://github.com/h5p/h5p-php-report/pull/8)

  10. h5p-video: Use undocumented no-cookie option for YouTube videos (https://github.com/h5p/h5p-video/pull/35)

  11. h5p-dialogcards: Fix setting focus on iOS13 (https://github.com/h5p/h5p-dialogcards/pull/64)

  12. h5p-branching-question: Fix getClosestParent() on IE11 (https://github.com/h5p/h5p-branching-question/pull/14)

  13. h5p-video: Add getCurrentState function for video (https://github.com/h5p/h5p-video/pull/25)

  14. h5p-editor-drag-question: Use user defined hover text for images in tasks (https://github.com/h5p/h5p-editor-drag-question/pull/13)

  15. h5p-drag-question: Use user defined hover text for images in tasks (https://github.com/h5p/h5p-drag-question/pull/45)

Acceptance Criteria

None

Assignee

Unassigned

Reporter

Oliver Tacke

Labels

Funding

None

Code reviewer

None

Released

None

Priority

Medium
Configure