ContentHubUI: Finish detailed view

Description

Acceptance Criteria

  • There are several TODOs in the detailed view of the content hub client, these must be finished, e.g:

    • H5P type

    • language

    • disciplines

    • level

    • size

Acceptance Criteria

None

Activity

Show:
Frode Petterson
June 22, 2020, 6:58 AM

That is correct. I just saw that these are the "machine labels" and not the human-friendly ones. We need to find a way to look these up.
For the ‘H5P type' we have to use the ‘title' attribute that comes in the content-type-cache data.For the language, disciplines, and level we must use the 'translation' value that comes from the metadata-cache data. If we cannot find any human-friendly value it’s OK to use the machine one.
Size I believe is already correct. (as long as we're using the 'size' property from the search data)

hanna.solstad
September 17, 2020, 12:51 PM

Why was this moved from improvement to selected for development?

Pål Jørgensen
September 17, 2020, 12:55 PM

It probably was me doing a bulk operation, and unintentionally including this one Will move it back.

Erik Langhaug
September 18, 2020, 12:47 PM

Good work Hanna! Here’s a rather delayed review for work you did 3 months ago, yay! I’ve been going up and down the component tree, trying to understand the data flow, and what you’ve done here works well.

I do however think that the Content and InfoList components could be simplified a bit just by moving the retrieval of the human-friendly labels up to the ReuseContent component, and then pass those real strings directly to Content, and then forwarded to InfoList as props.

Right now, we’re forwarding props that aren’t actually needed (for example the entire metaData object that contains a bunch of strings) just to be able to search inside it.

Erik Langhaug
September 23, 2020, 11:56 AM

Nicely done with the latest changes

Assignee

hanna.solstad

Reporter

Thomas Marstrander

Funding

None

Code reviewer

Erik Langhaug

Released

None

Time tracking

1h

Sprint

None

Priority

Medium
Configure