ContentHubUI: Fix TODOs or create Jira issues and remove TODOs from code

Description

Acceptance Criteria

1. If the TODO is simple fix it, if not create Jira issues for them.
2. The code should be free of TODOs after this issue. Placeholders for postponed functionality is OK.

Acceptance Criteria

None

Activity

Show:
Erik Langhaug
September 24, 2020, 1:33 PM

If it’s not broken, don’t fix it, right? could you please comment on this?

Erik Langhaug
September 24, 2020, 1:53 PM

These two TODOs seem to be referring to nonexistant filter options. So, I’m really not sure if these are filter options we want to add?

It would mean two new choices “Cannot be modified” and a “Does not allow commercial use”

And a “Show only content that has not been reviewed”

or what are your thoughts?

Jelena Milinovic
September 24, 2020, 2:20 PM

Isn't this handled already?
For "License" we show the number of choices we made and for "Reviewed" checkmark?

Erik Langhaug
September 24, 2020, 3:59 PM
Edited

No, I'm talking about being able to for example search for the opposite of "reviewed". That is, finding ONLY content that has NOT been reviewed. Currently, the filters offer no such option. So the question is, is it needed? Same thing for license filters. As a user, how can I find all content that does NOT allow commercial use (for whatever reason...)?

Jelena Milinovic
September 25, 2020, 7:53 AM

Oh, I see.

For the "Quality" filter we only planned the possibility to filter on "Quality approved". Later this filter was renamed to "Reviewed". I would suggest we leave it like it is for now until we get feedback from users. I don't think filtering on "non-quality" content will be that often but we'll see what users have to say!

For License, this filter has not yet been implemented completely. We postponed the additional dropdown "Select specific licenses" which will cover the use-case you described by selecting non-commercial licenses. Here, I suggest not doing any temporary solution and wait until we have this selector in place.

do you agree?

Assignee

Erik Langhaug

Reporter

Frode Petterson

Funding

None

Code reviewer

hanna.solstad

Released

None

Time tracking

6h

Priority

Medium
Configure