Review of H5P Advent Calendar

Description

Acceptance Criteria

  • Oliver received UX feedback

  • Code has been reviewed and Oliver has received feedback

  • Oliver has improved code according to review(s)

  • Content type has been released

Background

I was urged to create an advent calendar for H5P about four weeks ago and I didn't really have the time to create one. Stupid as I am, I decided to give it a try when I got bored of the US election progress. What you are about to review is the result of roughly 2 days of merely hacking away without a real plan, so be gentle

Features in a nutshell:

  • Enable authors to add texts, images, audios or videos to 24 doors.

  • Enable authors to style the calendar (background image, door front covers, etc.).

  • Enable authors to optionally add background music that may autoplay.

  • Enable authors to add snow.

  • Enable users to open a door if it's December and the current day is larger than or equal to the door number.

  • Enable users to toggle the background music on and off.

  • Supports H5P's save content state feature.

Notes:

  • The icon is a placeholder

  • The content type is not really accessible yet. It features keyboard usage and some aria labels, but it is not fit to be used together with readspeakers. Won't be able to improve that in 2020.

  • Even if you're very quick with reviewing, releasing and sending out some news, there's not much time until December 1, 2020 - so maybe it was smarter to do a thorough review, to give me enough time for improvement and release this one late in October 2021 or early in November 2021.

Site for testing: usual place
Code: https://github.com/otacke/h5p-advent-calendar
Demo: https://www.olivertacke.de/labs/2020/11/06/ho-ho-ho-now-i-have-an-advent-calendar/

Acceptance Criteria

None

Activity

Show:
Oliver Tacke
November 26, 2020, 9:30 AM

Yes. But since you don’t seem to like that, I added a fix for the doors that don’t have images on them

Jelena Milinovic
November 26, 2020, 2:18 PM

Amazing job Oliver! I like the level of customization that comes with this content type!

Here are some comments:

  • Behavioural settings are usually importance lvl3 - like "Text overrides".

  • It would be nice to use the regular "Close" button we have on popups. This one reminds me of the "Delete" functionality

  • It would be nice to close a popup by clicking anywhere outside of it

  • Main audio has to be paused to play the audio content. This is a bit of a hassle

  • I know this is an edge-case but, when there is nothing below the number, it feels strange not showing anything. For content - we get the popup - but if no content is attached to the door, the door will just open and I wait to see what will happen but nothing does Maybe we can have a popup with some sort of a message, like "Nothing to show here!"?

  • I see you mentioned: "Save content state". Does it mean it is possible to save the doors we already open, next time you access the content? - It would be an amazing feature!

  • When I open a door and see the content (audio for example) there is no indication that I can play this audio again - and I can! Some sort of indication that the content could be seen again would be nice!

And some features:

  • Love the snow feature! Maybe you can make it start snowing automatically one day before Christmas? 🎄

  • It would be nice to be able to pick one custom image that would be applied to every door!

  • It would be nice with autoplay options for video and audio!

Once again, great work!

Oliver Tacke
November 26, 2020, 8:02 PM

All done, except for the snow on 23rd of December: Would you like that as an option or as automatic behavior? Oh, and yes, “save content state” is supported, so doors that were open once will remain open when you return later. Aaaand I wasn’t sure about how to indicate that open doors can be clicked on again to reopen the content beyond having the pointer cursor, so I added a small symbol that indicates the content type. That’s what you get if you let me think about this

Jelena Milinovic
November 27, 2020, 9:04 AM

Looks great!

Can you please just make a small CSS change? Could you apply the following:

To all the icons:

just to make them a bit smaller and not so prominent. The result should be:

Regarding the snow - I thought it would be nice as automatic behavior!

Oliver Tacke
November 27, 2020, 9:40 AM

Done.

Done

Assignee

Frode Petterson

Reporter

Oliver Tacke

Labels

Funding

None

Code reviewer

None

Released

None

Time tracking

0m

Time remaining

0m

Sprint

None

Priority

Medium