Virtual Tour: Support multiline labels (collapse/expand)

Description

see El 02. Max width - V2: https://preview.uxpin.com/ee283b5f079a340070f36f93c77f0ed86ecbe762#/pages/121847785/simulate/sitemap?mode=i#TextElementff0586a15b0e4499b6813ca3cb2767dc

Acceptance Criteria:

  • The size should be the same as before it expanded. When expanding the should be shown above or beneath depending of alignment.

  • It has to be accessible. Meaning that it need to be possible using keyboard only and also with NVDA.

  • If the expansion causes overflow out of the image (when fixed) this it has to handled. TBD

  • The expansion button should only be show if the text trunctates

Acceptance Criteria

None

Activity

Show:
Jelena Milinovic
December 10, 2020, 10:29 AM

It would be nice to expand/collapse with an animation!

Hanna Eide Solstad
December 15, 2020, 7:06 PM

The expand button is not visible, so could you first fix that and then I will have a look at the rest

Simon Date
December 17, 2020, 9:45 AM
Edited

and I agree that when the label is in the top position the arrow icon should be above and point upwards since this is where the expand is moving to.

Hanna Eide Solstad
December 17, 2020, 12:31 PM

Looks great !

I have added some comments on github as well as one here:

  • There is now scrollbars shown, this shouldn’t be the case

Simon Date
December 17, 2020, 3:40 PM
Edited

these aren’t showing on MacOS but I’ve changed overflow: scroll to overflow: auto which should fix this. Can you review please?

Done

Assignee

Simon Date

Reporter

Pål Jørgensen

Labels

None

Funding

None

Code reviewer

Hanna Eide Solstad

Released

None

Time tracking

0m

Time remaining

0m

Sprint

None

Priority

Medium