Virtual Tour: Handle labels expanding out of image
Description
Acceptance criteria
If alignment is top/bottom it should be switched to opposite alignment if overflowing when expanded.
If alignment is left/right, the alignment should not change, but the expansion direction should be opposite if it would overflowed when expanded.
When having label shown only on hover the label should be shown as a whole with the same expansion rules as above.
Acceptance Criteria
Activity
The issue is only prevalent on Static Scene
Looks very good overall! I added a handful of comments on github I see you’re already on top of.
And I’ll just make a note here that I found that left-aligned labels don’t seem to “flip” expansion direction as expected when overflowing bottom (which we already discussed in chat).
Thanks for the feeback, very good comments that I will fix.
Good changes, especially DRYing up the css with those two mixins.
The label expands in a different direction as expected now, also for left and right aligned.
Very nice job
Assignee
Reporter
Labels
Funding
Code reviewer
Released
Time tracking
Time remaining
Sprint
Priority
