Virtual Tour: Handle labels expanding out of image

Description

Acceptance criteria

  • If alignment is top/bottom it should be switched to opposite alignment if overflowing when expanded.

  • If alignment is left/right, the alignment should not change, but the expansion direction should be opposite if it would overflowed when expanded.

  • When having label shown only on hover the label should be shown as a whole with the same expansion rules as above.

Acceptance Criteria

None

Activity

Show:
Simon Date
December 31, 2020, 9:21 AM

The issue is only prevalent on Static Scene

Erik Langhaug
January 12, 2021, 10:59 AM

Looks very good overall! I added a handful of comments on github I see you’re already on top of.

And I’ll just make a note here that I found that left-aligned labels don’t seem to “flip” expansion direction as expected when overflowing bottom (which we already discussed in chat).

Hanna Eide Solstad
January 12, 2021, 11:00 AM

Thanks for the feeback, very good comments that I will fix.

Erik Langhaug
January 12, 2021, 2:17 PM

Good changes, especially DRYing up the css with those two mixins.

The label expands in a different direction as expected now, also for left and right aligned.

Very nice job

Done

Assignee

Hanna Eide Solstad

Reporter

Hanna Eide Solstad

Labels

Funding

None

Code reviewer

Erik Langhaug

Released

None

Time tracking

0m

Time remaining

0m

Sprint

None

Priority

Medium