The text in the editor is now just written directly in the code. It has to be translatable and added from a language package instead.
Sorry I just read the first two paras. You want to revert all the changes where I changed functional components into classes?
I’ve made the change in the 3rd paragraph. I wasn’t sure if you were suggesting I go back and change them back or if we should just leave it?
I am thinking you should revert the changes back to functional components, as it is best practice. It shouldn’t be worse than taking the old change and just sending in the text as a prop instead.
Good job fixing those components. In this commit i made some changes to the propnames to make it more clear, as well as adding it to the propTypes as we should be doing for all props, but you were probably not aware since it wasn’t done for the h5p-three-image library. Please have a look at the commit. There was also one fix to stop it from failing.
Yeah, I did think the props names were a bit weird (as they could easily not be read correctly). Good change