Virtual Tour: Make editor text translatable

Description

The text in the editor is now just written directly in the code. It has to be translatable and added from a language package instead.

Acceptance Criteria

None

Activity

Show:
Simon Date
January 11, 2021, 8:33 AM

Sorry I just read the first two paras. You want to revert all the changes where I changed functional components into classes?

Simon Date
January 11, 2021, 9:03 AM

I’ve made the change in the 3rd paragraph. I wasn’t sure if you were suggesting I go back and change them back or if we should just leave it?

Hanna Eide Solstad
January 11, 2021, 9:17 AM

I am thinking you should revert the changes back to functional components, as it is best practice. It shouldn’t be worse than taking the old change and just sending in the text as a prop instead.

Hanna Eide Solstad
January 12, 2021, 2:38 PM
Edited

Good job fixing those components. In this commit i made some changes to the propnames to make it more clear, as well as adding it to the propTypes as we should be doing for all props, but you were probably not aware since it wasn’t done for the h5p-three-image library. Please have a look at the commit. There was also one fix to stop it from failing.

Simon Date
January 13, 2021, 4:41 PM

Yeah, I did think the props names were a bit weird (as they could easily not be read correctly). Good change

Done

Assignee

Simon Date

Reporter

Hanna Eide Solstad

Labels

Funding

None

Code reviewer

Hanna Eide Solstad

Released

None

Time tracking

0m

Time remaining

0m

Sprint

None

Priority

Medium