Virtual Tour: Make labels look 2d

Description

Currently the button and the text is made into 3d. This makes the text difficult to read if it is not in the center of the image. Should look something like this: https://www.eyespy360.com/en/feature/EyeSpyPLAN.html

Looking into https://threejs.org/docs/#examples/en/renderers/CSS2DRenderer and this example is probably a good start: https://threejs.org/examples/#css2d_label

Current label:

Acceptance Criteria

None

Activity

Show:
Hanna Eide Solstad
January 15, 2021, 11:46 AM

Thanks for the feedback! I will look into it.

Regarding your first comment:

  • Do they get cut off without showing the expand button? Is this in the 360 view?

  • Good spotted, haven noticed this before, but was able to reproduce once so will look into it.

For the other issues I have some questions.

  • A upgrade script has been made in another issue that will fix that, when run I assume.

  • Could you screenshot this?

  • Have you done something special when the tooltips text is missing? Not able to reproduce that.

  • Not able to reproduce that either, is it only for old content? Could you share a screenshot?

Thomas Marstrander
January 18, 2021, 1:09 PM
Edited

Some iissues may be related to the label text not actually being set, and instead inferred from the metadata title.

  1. There is no expand button when this happens, and yes, in 360. looks like this:

     

  2. Looks like this works nicely now

  3. There’s a console.log in the code now

Other:

  1. If you add defaults for this the content will not crash if they watch the content before having run the upgrade script

  2.  

  3. Not sure how this happened, it works fine now at least.

  4. This happens for new and old content:

Hanna Eide Solstad
January 19, 2021, 10:24 AM

Thanks for the screenshots, I will create a new issue for these, since it is not really related to this issue.

Hanna Eide Solstad
January 19, 2021, 11:46 AM

For the other issues number 2, please let me know if it fixed now. If not, are you seeing this when you have hover only or shown setting? Because it is supposed to have a white hover effect, but you should be seeing the arrow as well.

Thomas Marstrander
January 19, 2021, 12:59 PM

Seems to be fixed now, yes

Done

Assignee

Hanna Eide Solstad

Reporter

Hanna Eide Solstad

Labels

Funding

None

Code reviewer

Thomas Marstrander

Released

None

Time tracking

0m

Time remaining

0m

Sprint

None

Priority

Medium