Moodle 3.2 compatibility

Description

None

Acceptance Criteria

1. Test and fix problems with Moodle 3.2 - ref: https://h5p.org/node/38304
1.1. Theme problem

Activity

Show:
Pål Jørgensen
January 5, 2017, 12:21 PM

The implemented solution does not work when changing the theme to e.g. "clean". It seems the theme is responsible for rendering the DOM as well, not only styling.

Tom Arild Jakobsen
January 6, 2017, 7:18 AM
Edited

Created a new commit, where the old solution is used for all themes, except Boost, which bugged out (as we remember). The Boost theme now gets a html-field rendered as a single element, inside a group, with a label.

Tom Arild Jakobsen
January 6, 2017, 7:22 AM

Note that the group field, with the html field inside doesn't work for all other themes, so it can't be a replacement for all themes.

There also isn't any markup rendered anymore by our code.

Pål Jørgensen
January 10, 2017, 12:29 PM

Still seen:
H5P file upload is shown always (i.e. also if "create" is selected)

Tom Arild Jakobsen
January 11, 2017, 10:35 AM
Edited

Updated form javascript to be able to hide HFP file upload in this commit.

Created new selectors that is tested and works in Moodle 2.7, 3.1 and 3.2, for themes:

  • boost

  • clean

  • more

Done

Assignee

Tom Arild Jakobsen

Reporter

Svein-Tore Griff With

Labels

None

Funding

None

Code reviewer

Pål Jørgensen

Released

None

Time tracking

0m

Time remaining

8h

Fix versions

Priority

Medium