PR: Transparent audio

Description

None

Acceptance Criteria

Activity

Show:
Pål Jørgensen
May 3, 2017, 9:44 AM
Edited

: I am about to release this one, and have done some regression testing. Several things:

  • It breaks audio in dialog cards:

  • The new option is called "transparent", but for me it looks "invisible" is more descriptive.

  • Using it standalone looks really strange (Nothing displayed within a very low H5P)

  • Wrongly formatted semantics.json

  • Language files are not updated

  • Strange characters in both json and js:

I really think this should have been rejected...

Svein-Tore Griff With
May 3, 2017, 12:39 PM

Ok, just revert it if possible and give the contributor feedback on this.

Svein-Tore Griff With
May 3, 2017, 12:39 PM

note the test scenarios used here that you probably forgot about.

Frode Petterson
May 3, 2017, 1:23 PM
  1. Must have forgotten to test in DC. Fixed it by removing the new classname and using the old CSS.

  2. Transparent should be correct for elements you can interact with but not see. If it's invisible or hidden you cannot interact with it.

  3. I noticed this but thought it was OK.

  4. Couldn't find any wrong with the formatting but there was an extra indent.

  5. Updated.

  6. I believe I removed these after merging it in – unable to find these characters now at least.

Done

Assignee

Frode Petterson

Reporter

Svein-Tore Griff With

Funding

None

Code reviewer

None

Released

None

Time tracking

0m

Time remaining

2h

Sprint

None

Fix versions

Priority

Medium