Open issues

H5P Embed view in Drupal 8 does not trigger any hooks
HFP-2814
Update H5P hub with a newer version of Find Multiple Hotspots library
HFP-2763
Remove usage of external fonts in H5P
HFP-2759
Interactive Video - Submit screen doesn't show all the activities
HFP-2716
Moodle: Reports of Branching Scenario looks bad and gives php warnings
HFP-2704
The submit screen in Interactive Video must be moved if the video is made shorter
HFP-2661
Branching scenario CSS classes are applied to another content types
HFP-2641
CP - Go to slide fix
HFP-2573
Moodle: Implement missing privacy API functions
HFP-2553
Remove external font from Audio Recorder
HFP-2416
Moving of the nodes
HFP-2411
CP: Make sure focus is not lost when using menu and progressbar navigation
HFP-2396
Course Presentation - Interactive video stuck seek bar
HFP-2394
CKEditor constantly changes its height while typing
HFP-2280
Update list of content types with xAPI support
HFP-2279
Missing optional dependencies prevents content upgrade from running
HFP-2163
Course Presentation - Text gets cut off
HFP-2161
Require user input before the solution can be viewed option should be removed for Drag and Drop.
HFP-2159
Image Hotspots - Hotspot marker covers the background image
HFP-2151
CP with Video without any supported format crashes on iOS
HFP-2144
Solution for fill in the blanks is not readable on iPhone(Safari)
HFP-2106
Fonts are too big on IV example content on iPhone
HFP-2105
Course Presentation - Comments doesn't work for non graded activities
HFP-2031
Course Presentation - Slide menu opacity not working
HFP-2030
Drag the Words - Misalignment when embedding in Moodle
HFP-2024
IV: Captions not always available in mobile view
HFP-2021
CP - Specific slide number
HFP-2017
CP distorts images (incorrect ratio for uploaded images)
HFP-2008
CP: An object should not move when selected
HFP-2006
CP: Misaligned summary-slide buttons on IE11 & Edge
HFP-2004
Moodle: Respect the Moodle system settings for uploaded file's size
HFP-1996
Drag and Drop - Scoring issue with multiple correct solutions and static texts
HFP-1972
D8: Embed stops working (for anonymous users) after cache is cleared
HFP-1971
Docs: Improve developer docs based on community feedback
HFP-1966
IV: HTML5 videos don't continue properly after dismissing an interaction
HFP-1959
CP inside Column will open the editor at the first CP's location, confusing users
HFP-1956
Drag & Drop with multiple draggables using keyboard navigation
HFP-1939
Documentation tool - Extra strings in exported text
HFP-1927
Embed does not work by default for Speak The Words
HFP-1924
Drupal8: Internal Server error when creating H5P node
HFP-1921
Completely disable H5P.org content types
HFP-1908
Loading indicator for the libraries
HFP-1892
D8: H5P lost in paragraphs
HFP-1890
Add/remove Content types inside Column/Question Set
HFP-1888
IV: Video state not updating properly with navigational hotspots in IE.
HFP-1870
Review Content Type - Random Wheel
HFP-1866
Hub: Make it possible to update non runnable libraries without also updating the runnables
HFP-1862
Moodle: Add "require passing grade" to H5P activity completion criterias
HFP-1853
IV Editor: content-user-data is fetched 3 times
HFP-1849
Moodle: Translation of unmapped errors from core
HFP-1845
issue 1 of 903

H5P Embed view in Drupal 8 does not trigger any hooks

Description

No hooks are triggered for the Embed view of H5P content, which is inconsistent with behaviours of other views and does not work as expected.

Please see https://www.drupal.org/project/h5p/issues/3031362 for more details.

The issue above does not mention the embed header scripts hook, though that one is also required.

I have cloned the h5p repository from GitLab (8.x-1.x branch) and pushed the changes into GitHub. This commit solved it for me (only the tags hook is currently being used, but others should also work well enough):
https://github.com/pjotrsavitski/h5p/commit/1ec79a6d9904d58249d0bbfe06ab1ea366993569

The solution might be missing something and it should probably be better to create some reusable code for both views, but it seems to be working wee enough for now.

It would be great if this would be fixed soon and released as part of RC15. I am more than happy to make any changes to the code so that it would be accepted and merged.

Environment

None

Acceptance Criteria

None

Status

Assignee

Unassigned

Reporter

Pjotr Savitski

Labels

Funding

None

Code reviewer

None

Released

None

Time tracking

0m

Fix versions

None

Sprint

None

Priority

Highest