All issues

H5P Embed view in Drupal 8 does not trigger any hooks
HFP-2814
360 Virtual Tour: Should be possible to pick an icons for the scene
HFP-2746
360 Deploy testable version
HFP-2602
Dialog cards not displayed when navigating back and forth
HFP-2509
English default texts are not loaded in editors if a unsupported language is active
HFP-2392
Latest H5P Moodle release is incomatible with PHP 5.6
HFP-2152
Quizzes qith question pools don't update the max score on retry
HFP-2138
Course Presentation summary UX problems
HFP-2066
Polish 360image prototype
HFP-1995
IV: LRS/reporting functionality shall not be present if not supported by platform
HFP-1994
CP: Editor crashes when sorting slide
HFP-1968
Moodle: Fix Moodle theme css bleeding into H5P content when embedding.
HFP-1889
Add back the hover effects within drag and drop
HFP-1865
Only add drop zone title attribute if label is showing
HFP-1864
D8: Embed failing with php exception
HFP-1859
Course Presentation - Changes not saved in WP when using Safari
HFP-1826
Avoid being hit by add blockers
HFP-1816
.h5p files downloaded from test.h5p.com are broken
HFP-1814
Documentation Tool - Incorrect Settings in Sample page
HFP-1790
CP Editor: Not able to remove/delete content
HFP-1738
DnD: Calculation of score is wrong
HFP-1719
Outline when editing IV
HFP-1713
Documentation tool titles look like input fields
HFP-1693
Interactive Content : Vimeo videos not working
HFP-1692
Find the hotspot: Missing padding
HFP-1683
Questionnaire on staging missing label on continue button
HFP-1682
Requesting Word Find Game Review
HFP-1671
Documentation Tool: Unable to view all content
HFP-1566
Requesting H5P Image Pair Review
HFP-1511
Show Solution doesn't work if Sound effects is disabled
HFP-1494
CP: "Go to slide" does not work propely
HFP-1489
CP: bug in SSC
HFP-1385
Uploaded files unintentionally deleted in Drupal?
HFP-1207
PHP warning when installing and registering with H5P.org fails
HFP-1103
IE 11 crashing when checking answer of drag text
HFP-1070
Audio recorder not working in FF
HFP-1051
Moodle CSS + JS Hooks fails in editor
HFP-1041
Restore single h5p with grade fails in Moodle
HFP-1038
Add .wav to default whitelist in plugins
HFP-1035
Restoring course from hvp 1.0 into existing course in 'release' branch fails
HFP-1026
Review H5P.Timer fixes
HFP-876
Fieldset tags are gone in IE11
HFP-817
Mark the words scoring bug
HFP-798
Review new content type: Image Multiple Hotspot
HFP-790
WP Object Editing Error
HFP-784
Column: Group header in column is not updated
HFP-770
Editor: List group headers size issue
HFP-763
Moodle - Can't open IV or CP
HFP-717
Test and merge language changes
HFP-486
IV Summary broken on some devices
HFP-353
issue 1 of 2684

H5P Embed view in Drupal 8 does not trigger any hooks

Description

No hooks are triggered for the Embed view of H5P content, which is inconsistent with behaviours of other views and does not work as expected.

Please see https://www.drupal.org/project/h5p/issues/3031362 for more details.

The issue above does not mention the embed header scripts hook, though that one is also required.

I have cloned the h5p repository from GitLab (8.x-1.x branch) and pushed the changes into GitHub. This commit solved it for me (only the tags hook is currently being used, but others should also work well enough):
https://github.com/pjotrsavitski/h5p/commit/1ec79a6d9904d58249d0bbfe06ab1ea366993569

The solution might be missing something and it should probably be better to create some reusable code for both views, but it seems to be working wee enough for now.

It would be great if this would be fixed soon and released as part of RC15. I am more than happy to make any changes to the code so that it would be accepted and merged.

Environment

None

Acceptance Criteria

None

Status

Assignee

Unassigned

Reporter

Pjotr Savitski

Labels

Funding

None

Code reviewer

None

Released

None

Time tracking

0m

Fix versions

None

Sprint

None

Priority

Highest