Image hotspot - popup content outside frame

Description

The problem here is that the popup is placed wrong, so that parts of the bottom of the poup is outside the iframe. My guess is that this happened when we added the possibility to add several elements inside the popup. It seems the calculations in popup.js's self.show is not working correctly anymore. It might be related to updated paddings or margins...

Environment

None

Acceptance Criteria

Solve problem described here: https://h5p.org/node/72912 Comment on issue

Attachments

4

Activity

Pål Jørgensen October 17, 2017 at 11:58 AM

The last solution seems to cover all use cases

Pål Jørgensen October 10, 2017 at 1:02 PM

Your solution is working, except for the header that get's no spacing:

Andreas Nergaard October 10, 2017 at 8:55 AM
Edited

Made sure padding is included in the total height of the popup.
Made sure the user's content looks good, and checked against both short content and long content (scrollable)
http://redherring.joubel.com/drupal/node/11

Pål Jørgensen October 9, 2017 at 8:53 AM

Even with the overflow:auto I still see this problem locally:

Andreas Nergaard October 9, 2017 at 8:33 AM

Here is a direct link to test the newest fix:
http://redherring.joubel.com/drupal/node/11

Here is the original that is broken:
https://h5p.org/node/71923

Done

Details

Assignee

Reporter

Code reviewer

Original estimate

Time tracking

8.25h logged

Fix versions

Priority

Created May 5, 2017 at 7:45 AM
Updated October 19, 2017 at 11:28 AM
Resolved October 17, 2017 at 11:59 AM