Course Presentation: Interactive Videos inside dialog broken

Description

After the improvements in Var 2, Interactive Videos no longer displays properly in the dialog. See screenshot.

Environment

None

Acceptance Criteria

Interactive videos are displayed as previously when put inside a course presentation dialog.

Attachments

3

Activity

Frode Petterson October 10, 2017 at 1:27 PM

Great!

Tom Arild Jakobsen October 10, 2017 at 1:04 PM
Edited

Commited the fix , tagging it with the wrong task, but here is the fix to review.

It changes the proportions of IV and Video, so that 16:9 videos shows without a scrollbar.

Frode Petterson October 10, 2017 at 11:53 AM

The bug in the code is fixed, well done.

But the main issue here is the how videos are displayed inside the dialog. Previously, they were scaled to fit, like the images still are, like this:

Now it looks like this:

Perhaps there's some if statement no longer evaluating correctly?

Tom Arild Jakobsen October 10, 2017 at 9:55 AM

Svein-Tore Griff With October 10, 2017 at 8:26 AM

if posters still work it isn't a blocker, but it definitively needs to be fixed now.

Done

Details

Assignee

Reporter

Code reviewer

Original estimate

Time tracking

No time logged2h remaining

Fix versions

Priority

Created October 9, 2017 at 12:11 PM
Updated October 10, 2017 at 1:27 PM
Resolved October 10, 2017 at 1:27 PM