More compact feedback block
Description
Acceptance Criteria
Attachments
relates to
Activity

Thomas Marstrander May 16, 2018 at 1:37 PM
I've added titles for the buttons, but have not changed the rest of the issues since the logic is quite complex and I would not be comfortable fixing it quickly without breaking something else unfortunately. If you think its important please reopen the issue or create new issues, if we reopen it I think Pål should fix it as he already has invested a lot of time into understanding the logic

Jelena Milinovic May 16, 2018 at 11:03 AM
1. I agree we could have a bit longer scorebar if there are no buttons next to it ( case where the user answered 100% correct and cases like CP total on a summary page, SCS scorebar, Question set scorebar?
2.
If this is possible to achieve, if we know there is enough space to show buttons without showing a scrollbar it would be nice to have this.
Check attachment above, case 1.
I just noticed that we do not have tooltips, can you please add them for buttons - at the moment, without wording, it is hard to understand what an eye icon mean.
3. I don't think this ruins the experience a lot, but would be nice to get rid of it if it is quick

Thomas Marstrander May 16, 2018 at 8:51 AM
Perhaps you have some input on the questions in my previous comment ?

Thomas Marstrander May 14, 2018 at 12:35 PM
Works and looks very nice, good job. I have a bit of feedback and some questions about functionality:
It seems like scorebar always uses the minimum width unless the buttons wrap under it, is this intended ? You can see this on page 6 in CP example content
In CP the buttons are positioned on the same line as scorebar truncated for fitb even though there is plenty of room under it. It looks a bit strange and inconsistent with how it was before. See page 3 in CP.
When you resize CP the truncated buttons keep jumping up and down for the FITB in CP example.

Jelena Milinovic April 26, 2018 at 11:05 AM
Works and looks very nice Pål!
Acceptance criteria for this issue are OK but I noticed that some of the buttons are not showing as expected, I explained it below in details. Please move my comments to a new issue if you want to handle this as a separate issue.
IV:
SCS: Buttons are not showing ( looks like it never switches to the last slide of SCS)
MC: Even though I got the max score I still see "Show solutions" and "Retry button". In this case, I should see only "Continue"
DnD: Same as above, "Retry" is shown even if I got the max score
Drag text (button mode): If I answer and don't check but proceed and than I open the question again, buttons get misaligned (check 01.png)
QS:
MC and DnD - same as in IV, they should not have "Retry" button if the max score is achieved
In "Show solutions mode" of the entire QS we should not get "Retry" button for the activities that have been scored 100%. ( FITB, MC do not behave as expected )
In show solutions mode of the entire QS we should get "Retry" in DnD if the max score is not achieved
Details
Assignee
Pål JørgensenPål JørgensenReporter
Pål JørgensenPål JørgensenFunding
NDLA microserviceCode reviewer
Thomas MarstranderThomas MarstranderOriginal estimate
30hTime tracking
No time loggedSprint
NoneFix versions
Priority
Medium
Details
Details
Assignee

Reporter

Funding
Code reviewer

Acceptance criteria
Placement of buttons like "show solution", "retry" and so on shall be placed on the right side of the scorebar, like this:
Rules:
If not enough space available for textual buttons, truncate them
Still not enough space, move it below the scorebar
If not enough space available for textual buttons, truncate them
The scorebar's minimum width shall be set lower than today. : Need your input here.
Note: This also goes for the buttons added by QuestionSet and InteractiveVideo. E.g: