QS: Add option for removing 'Check'

Description

H5P.MultiChoice,
H5P.DragQuestion,
H5P.Blanks,
H5P.MarkTheWords,
H5P.DragText,
H5P.TrueFalse:

  • Add a new field in semantics in the behavior group. Name it enableCheckButton. Default on. Widget: "none", so that it is not shown in editor. We only want this feature through QS, not for standalone question types.

  • In constructor: give it a default value to true.

  • Add logic to not show button if enableCheck === false

  • Update translation files

H5P.QuestionSet

  • Add a new field in semantics in the override group. Name it checkButton, and make it into a boolean field. Default value is true.

  • See how showSolutionButton and retryButton are used, and add support for checkButton. Since this will be a boolean field, it shall always be set.

  • If checkbutton is off, remove settings for retry/showsolution in editor using the showWhen widget

  • Update translation files

  • No need for content upgrade

Remember that in QS you have the show solution and retry button on the last slide. You need to test these scenarios to be sure the check button doesn't show when in solution mode.

Acceptance Criteria

Question Set 1. Add option that removes the check button for all questions inside it ("Show Check buttons" in the editor) 2. For existing Question Sets the check button should be present (i.e. we don't wanna change existing content) 3. Default behavior when creating new QuestionSets should be that the check button is shown 4. Make sure the "check" button is not shown when clicking "show solution" and "retry" on The Question Set's summary page When released, update https://h5p.org/node/19450

Activity

Bienvenido Villadelrey November 23, 2017 at 1:11 PM

1. Created a QS with all content types using default settings. The content behaved as expected showing buttons that functions as intended. Scores are shown with the correct computation. Solutions where also shown when applicable.

2. Unchecking 'Show "Check" buttons' is exhibiting the desired result. All check buttons for all questions are not showing and the only option is to click next/back. Although for the case that triggered the change we need to make sure that the user is informed to uncheck the displays results so that no scores are presented.

3. Overall the functionality of the content is satisfactory. Expected behaviours are exhibited .

Pål Jørgensen November 3, 2017 at 9:20 AM

Looking good! No problems found!

Andreas Nergaard November 3, 2017 at 7:45 AM

Seems like it haulted my push and I didn't notice straight away, should be updated now.

Pål Jørgensen November 2, 2017 at 3:57 PM

There's still the issue with H5P.Multichoice I mentioned above.

Andreas Nergaard November 1, 2017 at 11:37 AM

I think it's all good now

Done

Details

Assignee

Reporter

Code reviewer

Original estimate

Time tracking

22h logged

Sprint

Fix versions

Priority

Created September 28, 2016 at 7:53 AM
Updated November 23, 2017 at 1:11 PM
Resolved November 3, 2017 at 9:20 AM