Submit button in IV is gone

Description

from otacke:
Has someone possibly forgotten to set the new isScoringEnabled and isReportingEnabled flags to the plugins as needed or released the latest version of Interactive Video prematurely? The plugins still only know the reportingIsEnabled setting in H5PIntegration but don't pass it to the content data for H5PRunnable as far as I can see. There's no submit button on IV anymore (outside of H5P.com) ... I assume IV should have kept a fallback as Documentation Tool? https://github.com/h5p/h5p-documentation-tool/commit/a65f943c7571b7acd69eecdcae0b4085ff0fa92c#diff-590ebde0d84de52c188b[…]8c52d5b21821875c02c52e8R29

Environment

None

Acceptance Criteria

None

Activity

Pål Jørgensen January 3, 2022 at 1:04 PM

Great work. It is released now!

Oliver Tacke January 3, 2022 at 10:31 AM

Hotfix proposed at . A different approach could be to always display the submit button if isScoringEnabled and isReportingEnabled both are undefined. That way the current behavior would be maintained instead of forcing thousands of people to turn on “LRS dependent content types” out of the blue. I’d prefer that. However, I don’t know the specification of those two flags. isScoringEnabled and isReportingEnabled could strictly be a boolean, and then there’s no way to distinguish both flags from being turned off deliberately or by omission (in the current plugin versions). Could be changed as well once the hotfix fixes the issue.

Done

Details

Assignee

Reporter

Priority

Created January 3, 2022 at 10:07 AM
Updated January 3, 2022 at 1:04 PM
Resolved January 3, 2022 at 1:04 PM