Re-review "Advent Calendar"

Description

acceptance criteria

  • Code in version 0.3 is fine for an update.

    • Master branch is at

  • Content type works well (new features only)

    • When the author selects “H5P shall set the door images based on the background image” (new default) and has set a background image in the visual setting, the background (seemingly) covers the whole calendar and the doors' background is set with the respective clipping of the background image.

    • When the author selects “Dynamic” mode for door placement (new default), the number of doors displayed horizontally and vertically (currently fixed at 6 x 4) will adjust to the available width (6 x 4 => 4 x 6 => 3 x 8 => 2 x 12) to improve the display on smaller screens - but then not being able to fully display the background image anymore.

    • When the author selects “Fixed” mode for door placement (6 x 4 or 4 x 6), the aspect ratio is kept.

    • The parameters of existing content get upgraded properly to the new version.

background

X-Mas season is nearing and Advent Calendar has received a couple of updates, and those should please be released on the H5P Hub.

Notable changes since 0.2.5 which is used on :

  • Feature: Added mode to automatically clip images for the doors from the background image.

  • Feature: Added dynamic row-to-column-ratio option

  • Feature: Rearranged the editor options into categories (visual, audio, behavioral).

  • Fix: Snow now really starts to fall off screen.

  • Translations: Added Slovenian translation (contributed by miropuhek).

Acceptance Criteria

None

Attachments

5

Activity

Oliver Tacke November 12, 2022 at 8:40 PM

While you're absolutely right, this bothers me. I like my things to work . Also, people will report this and blame H5P or Advent Calendar and not Safari. If someone complains about weird snow behavior on Safari, you can refer people to Apple … 😇

I hope to find some time to experiment when Browserstack introduces support for Safari 16.

Iryna Havrylova November 12, 2022 at 8:33 PM

Sometimes just leaving it as a known issue is the best thing we can do, we should not expect everything to be fixed no matter what Great job and efforts with digging into this, I suggest just waiting until Safari 16 is available on Browserstack (or it’s fixed from Apple side)

Oliver Tacke November 11, 2022 at 3:45 PM

I have been able to sit in front of Safari 16.1 on a Mac. The snow animation is there, but only renders every other second or so, so I can in fact reproduce the issue. But I don’t think that my code is really to be blamed here. It’s just a handful of CSS animations. All the other browsers can render the snow flakes flawlessly - and Safari before version 16 can as well. I just double checked on a physical iPhone with Safari 15. It’s not a performance issue, since rendering takes just a couple of ms and even a smartphone can display everything just fine. My best guess is that Apple messed up the CSS engine which they definitely touched for v16 in order to introduce parent and container selectors and probably more. Have you heard anything related to that or do you have any other idea?

So, summing up: I would not know what I could do to speed up things on Safari 16, and I don’t have Safari 16 at hand on Browserstack yet that would allow me to tinker with CSS in order to find a workaround (and working around browser’s bugs is not one of my favorite time fillers ).

Oliver Tacke November 11, 2022 at 11:27 AM

I have created and to add support for conditionally showing/hiding the buttons for adding tabs/removing tabs within the VerticalTabs widget.

This does not only solve the misleading behavior in Advent Calendar, but also in other content types that use the VerticalTabs widget while setting min/max values for the tabs, e.g. Interactive Book or Question Set.

Oliver Tacke November 11, 2022 at 10:15 AM

We could add another demo content as well. One to show how it will work in real life, one in design mode.

I have contacted Browserstack by the way. They strive to make newer OS/browser versions 30 days after those have been released to the public, so Safari 16 for MacOS should be available in approximately two weeks - kind of strange given that a developer version of MacOS Ventura has been around since June, but good to know. And I may get my hands on a physical Mac today …

Done

Details

Assignee

Reporter

Original estimate

Time tracking

No time logged

Sprint

Fix versions

Priority

Created September 23, 2022 at 1:36 PM
Updated November 22, 2022 at 9:33 AM
Resolved November 10, 2022 at 1:21 PM