Runaway script in Question Set (Visible in firefox on mac)

Description

Question set gets a 'timed out' error. Forum post:

https://h5p.org/comment/8861#comment-8861

Environment

None

Acceptance Criteria

- Fix bug - Post back to forum

Activity

Thomas Marstrander December 22, 2016 at 10:01 AM

Have updated forum

Timothy Lim December 22, 2016 at 7:17 AM

, would you be able to paste your discovery in the forum?

Thomas Marstrander December 21, 2016 at 10:51 AM

Returning if value is not an array or object will skip much of the traversal. If copyright is not the first field in a sequence of fields this will fail.

The actual issue seems to be that certain content types add objects such as jQuery elements and library instances to the parameters of sub-content before passing them along. Traversing these objects has no purpose. I have implemented a quick hack for ignoring all parameters in "overrideSettings" when traversing parameters, however this should be solved by cleaning up parameters in the future. We do not want to pollute parameters with non-canonical values. This could be solved by making parent call a setter for the sub-content instead, for instance. I have created an issue for addressing this in the future:

Done

Details

Assignee

Reporter

Code reviewer

Affects versions

Priority

Created December 20, 2016 at 2:43 PM
Updated April 20, 2017 at 9:09 AM
Resolved December 22, 2016 at 10:11 AM